Added South Africa and Germany Fieldscapes Converter #43
Conversation
aninda-ghosh
commented
Jun 6, 2024
aninda-ghosh
commented
- Added Converter for Fieldscapes subset for Germany. (Currently using local data)
- Added Converter for Fieldscapes subset for South Africa. (Currently using local data)
fiboa_cli/datasets/fs_de_bb.py
Outdated
| # Supported protcols: HTTP(S), GCS, S3, or the local file system | ||
|
|
||
| # Local URI added to the repository for initial conversion, Original Source https://beta.source.coop/esa/fusion-competition/ | ||
| URI = "/home/byteboogie/fieldscapes/germany/fs_de_bb.gpkg" |
There was a problem hiding this comment.
I'm not sure how to proceed with this. It's not really useful for the general public if there's no way to get the source data. Any thoughts from the fieldscapes members?
There was a problem hiding this comment.
Chrish asked to keep the local folder for now later we can change this to maybe Source URI? Not sure need extensive discussion on this.
fiboa_cli/datasets/fs_de_bb.py
Outdated
|
|
||
| # License of the data, either | ||
| # 1. a SPDX license identifier (including "dl-de/by-2-0" / "dl-de/zero-2-0"), or | ||
| LICENSE = "DL-DE->BY-2.0" |
There was a problem hiding this comment.
| LICENSE = "DL-DE->BY-2.0" | |
| LICENSE = "dl-de/by-2-0" |
fiboa_cli/datasets/fs_za_ct.py
Outdated
|
|
||
| # License of the data, either | ||
| # 1. a SPDX license identifier (including "dl-de/by-2-0" / "dl-de/zero-2-0"), or | ||
| LICENSE = "CC BY-NC-SA 4.0" |
There was a problem hiding this comment.
According to https://spdx.github.io/spdx-spec/v2.3/SPDX-license-list/ this should be:
| LICENSE = "CC BY-NC-SA 4.0" | |
| LICENSE = "CC-BY-NC-SA-4.0" |
There was a problem hiding this comment.
Yes I forgot to follow the SPDX format
fiboa_cli/datasets/fs_za_ct.py
Outdated
| # Function signature: | ||
| # func(column: pd.Series) -> pd.Series | ||
| COLUMN_MIGRATIONS = { | ||
| "area_m": lambda column: column * 0.0001 |
There was a problem hiding this comment.
Is this a left-over from the template?
There was a problem hiding this comment.
Yes it was a left over, fixed for now using the latest push
fiboa_cli/datasets/fs_za_ct.py
Outdated
|
|
||
| # Schemas for the fields that are not defined in fiboa | ||
| # Keys must be the values from the COLUMNS dict, not the keys | ||
| MISSING_SCHEMAS = { |
There was a problem hiding this comment.
crop_id and crop_name seem to be missing?!
There was a problem hiding this comment.
Fixed the issue with the latest push
I guess yes but after last meeting we have removed the grid id on the merged dataset. but crop id and crop_name are not consistent in the subset (So Need Discussion on this further ) |
|
Happy to help with the extension. |
|
Please rebase the PR to the latest CLI version, including renaming the URI constant to SOURCES and renaming the parameter cache_file to cache. I tried to push it upstream, but you didn't permit changes to this PR so you need to do these changes yourself. Thanks. |
